Coupon Start date issue

Author	« Topic »
ecws Advanced Member USA 173 Posts Pre-sales questions only (More Details...)	Posted - 05/31/2019 : 15:19:09 Coupons that have a NULL value for the cpnStartDate field are not properly handled. On upgrade, are you updating that date to '2000-01-01 00:00:00'? We may be adding coupons without start dates and the cart is not calculating the coupon value if the cpnStartDate is NULL. Dean ecomwebstore.com [img]http://www.ecomwebstore.com/images/ecw_sm.jpg[/img]
Andy ECT Moderator 95440 Posts	Posted - 05/31/2019 : 23:45:41 Hi Dean You should be able to set discounts without a start date but do you mean you are leaving that field blank and adding an end date or something else? Andy Please feel free to review / rate our software
Vince Administrator 42488 Posts	Posted - 06/01/2019 : 02:07:36 quote: On upgrade, are you updating that date to '2000-01-01 00:00:00'? Hi Dean Yes, the cpnStartDate is set to that value when updating. Are you having a problem? There is a fix in the incdiscounts.php file where the End Date could be incorrectly marked as Expired in case that has anything to do with this. Vince Click Here for Shopping Cart Software Click Here to sign up for our newsletter Click Here for the latest updater
Vince Administrator 42488 Posts	Posted - 06/01/2019 : 02:50:06 Hi Dean I've added a check for NULL also as it should be handled properly really anyway. I've added that change to the v7.1 updater incdiscounts.php file. You can use that with v7.0 if you are still on that version. Vince Click Here for Shopping Cart Software Click Here to sign up for our newsletter Click Here for the latest updater
ecws Advanced Member USA 173 Posts Pre-sales questions only (More Details...)	Posted - 06/03/2019 : 06:17:39 Thanks Vince. So does that mean that if cpnStartDate is NULL it will be treated as a "None" start date? Dean ecomwebstore.com [img]http://www.ecomwebstore.com/images/ecw_sm.jpg[/img]
Andy ECT Moderator 95440 Posts	Posted - 06/03/2019 : 07:36:10 My understanding is that on updating NULL will be changed to 2000-01-01 00:00:00 which effectively means there is no start date as such as it's in the past. Andy Please feel free to review / rate our software
Vince Administrator 42488 Posts	Posted - 06/03/2019 : 08:02:11 quote: So does that mean that if cpnStartDate is NULL it will be treated as a "None" start date? Actually, I don't think I've thought this through properly. What I did was handle the NULL in the admin, but in the cart a NULL would still not be handled properly. Can you maybe run a quick bit of SQL to set all start dates and end dates if they are NULL? On update and through the admin when adding discounts they should always be set with the default "not set" value. Vince Click Here for Shopping Cart Software Click Here to sign up for our newsletter Click Here for the latest updater
ecws Advanced Member USA 173 Posts Pre-sales questions only (More Details...)	Posted - 06/03/2019 : 13:38:29 I updated the MOD to include the cpnStartDate as '2000-01-01 00:00:00'. Everything works if that field has a set value. Dean ecomwebstore.com [img]http://www.ecomwebstore.com/images/ecw_sm.jpg[/img]
PieMan Advanced Member United Kingdom 272 Posts	Posted - 06/05/2019 : 04:19:17 Thanks all for your help on this. The mod is now working as designed with v7.1 of the cart. Regards Mike Using ECT since 2003. Edited by - PieMan on 06/05/2019 04:20:09
	« Topic »